Mail Archives: djgpp-workers/2002/06/08/07:46:59
Hello.
Eli Zaretskii wrote:
>
> On Wed, 29 May 2002, Richard Dawe wrote:
>
> > Please find below some fixes to *printf() with regards to passing
> > va_lists to _doprnt(). I don't think there's anything controversial
> > here.
> >
> > I've also included what I think we should do to confstr().
> > I don't think we need to call snprintf() just to truncate a string.
> >
> > If there are no objections, I'd like to commit these patches.
>
> These patches are fine with me. Thanks.
I've committed the *printf parts.
I've just discovered why we use snprintf in confstr(). You can pass NULL or a
zero-length buffer to confstr(). In these cases we don't want to touch the
buffer at all. So the patch is broken.
Which is preferable?
* Change confstr(), so it doesn't generate a warning.
* Change the Makefile, so the warning isn't fatal for confstr.c?
Bye, Rich =]
--
Richard Dawe [ http://www.phekda.freeserve.co.uk/richdawe/ ]
- Raw text -