Mail Archives: geda-user/2015/12/25/05:24:20
Hi Jan,
Jan Damborsky wrote:
> Deploying those tools on Solaris is straightforward, I justneed to deal
> with a small issue when building pcb - compilation fails due to following
> files missing <locale.h> header:
>
> $ git status -s
> M src/hid/gtk/gui-config.c
> M src/hid/gtk/gui-misc.c
> M src/hid/gtk/gui-netlist-window.c
> M src/main.c
> M src/print.c
> M src/report.c
>
> Adding <locale.h> to those filessolves the problem.
> Tried that on Linux as well (Ubuntu 14.04), but Linux doesn't complain
> which is perhaps the reason why that issue has not been reported so far.
> I am wondering if it would make sense to file bug for this and fix that.
I think so, we still need to find the right way to fix it.
> If desired, I am willing to do whatever is needed to integrate
> those changes into the upstream, just would need some guidance
> to go through the processes.
Filing a bug is a good first step. Next steps would be:
* find out why locale.h is required
* find out whether that is correct
+ if no, find what to do instead and implement that
+ if yes, check for locale.h in configure.ac and add #include within
#if HAVE_LOCALE_H in the source files where locale.h is required
* commit locally
* either: git format-patch -1, then attach patch to the bug
or: git push to somewhere and ask here for review+possible merge
//Peter
- Raw text -