ftp.delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-apps/2001/08/01/14:50:16

Mailing-List: contact cygwin-apps-help AT sourceware DOT cygnus DOT com; run by ezmlm
Sender: cygwin-apps-owner AT sourceware DOT cygnus DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT sources DOT redhat DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT sources DOT redhat DOT com>
List-Help: <mailto:cygwin-apps-help AT sources DOT redhat DOT com>, <http://sources.redhat.com/lists.html#faqs>
Delivered-To: mailing list cygwin-apps AT sources DOT redhat DOT com
Date: Wed, 1 Aug 2001 14:47:08 -0400
Message-Id: <200108011847.OAA32757@envy.delorie.com>
X-Authentication-Warning: envy.delorie.com: dj set sender to dj AT envy DOT delorie DOT com using -f
From: DJ Delorie <dj AT delorie DOT com>
To: cwilson AT ece DOT gatech DOT edu
CC: binutils AT sources DOT redhat DOT com, cygwin-apps AT cygwin DOT com
In-reply-to: <3B6846D2.9040206@ece.gatech.edu> (message from Charles Wilson on
Wed, 01 Aug 2001 14:13:38 -0400)
Subject: Re: [RFA] pei386 dll: auto-import patch
References: <3B670087 DOT 7090102 AT ece DOT gatech DOT edu> <200108011735 DOT NAA32231 AT envy DOT delorie DOT com> <3B6846D2 DOT 9040206 AT ece DOT gatech DOT edu>

> Ultimately, I believe the default should be "on"...eventually.

Agreed.  "Eventually" could be next week, if sufficient testing is
done.  I just get nervous about patches like this (big and tricky).
I'd rather make multiple little steps than one big one when possible.

> > The code style is wrong (binutils follows the GNU coding standards).
> 
> I'm not sure about this; I'll go thru the code and try to make the 
> spacing line up like the surrounding code. Is there something else I'm 
> missing?

Indentation (maintly the gory debug code), spaces around identifiers
(strcmp () instead of strcmp(), a + b instead of a+b), and don't put
the if on the same line as the printf.  Run the file through indent
and see what the differences are (although you may find changes
outside your patch too, nobody's perfect ;)

> > Do not use the term "bugger" in comments.  Please stick to technical
> > names, not derogatory ones.
> 
> ??? Where's THAT?  I'll find it and remove it.

+
+/* I don't know which bugger sets .idata as code */
+  {
+    asection *asec = bfd_get_section_by_name (output_bfd, ".idata");

> DJ, *thanks* for your comments.  I've been hoping someone more closely 
> allied with the main binutils development would take a look and comment 
> on this change.  I had felt that "we" have been operating in a vacuum...

No, I've been saving the emails and letting the back-n-forth settle
down so I could read them all at the same time (too many things going
on to keep every thread in my head at once).

Also, after you (or someone) demonstrate sufficient proficiency and
trust in this code, you (or someone) could volunteer to be a
maintainer of it, and be able to commit patches directly.  Something
to look forward too...

- Raw text -


  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019