ftp.delorie.com/archives/browse.cgi   search  
Mail Archives: cygwin-apps/2002/04/26/10:40:51

Mailing-List: contact cygwin-apps-help AT cygwin DOT com; run by ezmlm
Sender: cygwin-apps-owner AT cygwin DOT com
List-Subscribe: <mailto:cygwin-apps-subscribe AT cygwin DOT com>
List-Archive: <http://sources.redhat.com/ml/cygwin-apps/>
List-Post: <mailto:cygwin-apps AT cygwin DOT com>
List-Help: <mailto:cygwin-apps-help AT cygwin DOT com>, <http://sources.redhat.com/lists.html#faqs>
Mail-Followup-To: cygwin-apps AT cygwin DOT com
Delivered-To: mailing list cygwin-apps AT cygwin DOT com
Message-ID: <3CC9642C.8F60A523@yahoo.com>
Date: Fri, 26 Apr 2002 10:29:00 -0400
From: Earnie Boyd <earnie_boyd AT yahoo DOT com>
X-Accept-Language: en
MIME-Version: 1.0
To: Max Bowsher <maxb AT ukf DOT net>
CC: Corinna Vinschen <cygwin-apps AT cygwin DOT com>
Subject: Re: Minor bugfix for setup.exe - missing call to backslash() in
desktop.cc
References: <001601c1ed2b$f3424df0$42a18c09 AT wdg DOT uk DOT ibm DOT com>

You can avoid this by attaching a file with a .txt suffix.

Earnie.

Max Bowsher wrote:
> 
> This adds a backslash() call to fix strange behaviour when creating the Cygwin
> link on the start menu.
> Currently, the link is created with name 'Programs/Cygwin/Cygwin Bash
> Shell.lnk'. NB: those are slashes in the filename, not directory separators.
> It's a minor bug, because once Windows notices this, it interprets the slashes,
> and moves it into the intended directory structure - nevertheless, it would be
> good to fix it. Accordingly, here are 1-liner patch and changelog. Patch is both
> inline and attached for convenience, since it is so small.
> 
> My apologies for the ChangeLog not being indented properly - Outlook Express
> eats tabs.
> 
> Max.
> 
> ###BEGIN PATCH###
> diff -mru cvssetup/desktop.cc setup/desktop.cc
> --- cvssetup/desktop.cc Sun Mar  3 17:29:24 2002
> +++ setup/desktop.cc Sun Mar  3 17:23:41 2002
> @@ -143,7 +143,7 @@
>  static void
>  make_link (String const &linkpath, String const &title, String const &target)
>  {
> -  String fname = linkpath + "/" + title + ".lnk";
> +  String fname = backslash(linkpath + "/" + title + ".lnk");
> 
>    if (_access (fname.cstr_oneuse(), 0) == 0)
>      return;   /* already exists */
> ###END PATCH###
> 
> ChangeLog:
> 2002-04-26  Max Bowsher  <maxb AT ukf DOT net>
> 
>  * desktop.cc (make_link): Add backslash() for fname, so link is created
>  in proper directory, rather than with slashes in its name.
> 
> Max.
> 
>   ------------------------------------------------------------------------
>                                          Name: start-menu-shortcut-slashfix.patch
>    start-menu-shortcut-slashfix.patch    Type: unspecified type (application/octet-stream)
>                                      Encoding: quoted-printable

- Raw text -


  webmaster     delorie software   privacy  
  Copyright 2019   by DJ Delorie     Updated Jul 2019